> -----Original Message----- > From: Sebastian Falbesoner <sebastian.falbesoner@xxxxxxxxx> > Sent: 2022年11月19日 11:04 > To: Adrian Hunter <adrian.hunter@xxxxxxxxx>; Bough Chen > <haibo.chen@xxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx> > Cc: linux-mmc@xxxxxxxxxxxxxxx; Sebastian Falbesoner > <sebastian.falbesoner@xxxxxxxxx> > Subject: [PATCH] mmc: sdhci-esdhc-imx: correct CQHCI exit halt state check > > With the current logic the "failed to exit halt state" error would be shown even > if any other bit than CQHCI_HALT was set in the CQHCI_CTL register, since the > right hand side is always true. Fix this by using the correct operator (bit-wise > instead of logical AND) to only check for the halt bit flag, which was obviously > intended here. > > Signed-off-by: Sebastian Falbesoner <sebastian.falbesoner@xxxxxxxxx> Thanks for the catch. Please add the fix tag in the commit log, and then I can give my ack. Best Regards Haibo chen > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c > b/drivers/mmc/host/sdhci-esdhc-imx.c > index 31ea0a2fce35..ffeb5759830f 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -1512,7 +1512,7 @@ static void esdhc_cqe_enable(struct mmc_host > *mmc) > * system resume back. > */ > cqhci_writel(cq_host, 0, CQHCI_CTL); > - if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) > + if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) > dev_err(mmc_dev(host->mmc), > "failed to exit halt state when enable CQE\n"); > > -- > 2.34.1
