On Thu, Nov 17, 2022 at 01:57:13PM -0800, Kees Cook wrote: > The only comment I have is that maybe these cases can just be left as-is > with _below()? > > > - size_t len = get_random_u32_below(rs) + gs; > > + size_t len = get_random_u32_inclusive(gs, rs + gs - 1); > > It seems like writing it in the form of base plus [0, limit) is clearer? > > size_t len = gs + get_random_u32_below(rs); > > But there is only a handful, so *shrug* Okay, I'll drop that one. Jason
