Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:02 PM Vyacheslav Bocharov <adeep@xxxxxxxxx> wrote: [...] > +/* > + * Cfg_rx_phase: RX clock phase > + * bits: 9:8 R/W Generally register values should not be part of the dt-bindings. If we need to make the phases configurable through device-tree then I suggest using the human readable values (0, 90, 180, 270) instead of these register bits. That said, if for whatever reason we need to have #defines for this then they should be added with the dt-bindings patch (and also carry the dt-bindings subject prefix) instead of a separate patch. Best regards, Martin
