On Tue, 8 Nov 2022 at 02:25, Kunihiko Hayashi
<hayashi.kunihiko@xxxxxxxxxxxxx> wrote:
....
> @@ -228,6 +229,7 @@ static int sdhci_f_sdh30_remove(struct platform_device *pdev)
> #ifdef CONFIG_OF
> static const struct of_device_id f_sdh30_dt_ids[] = {
> { .compatible = "fujitsu,mb86s70-sdhci-3.0" },
> + { .compatible = "socionext,f-sdh30-e51-mmc" },
>
This also needs to be specified in the dt bindings, not just in the driver.
And if this patchset is for the "e51-mmc" type controller, introduce
the compatible first and apply the changes for that controller.
> @@ -258,4 +260,5 @@ module_platform_driver(sdhci_f_sdh30_driver);
> MODULE_DESCRIPTION("F_SDH30 SD Card Controller driver");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD.");
> +MODULE_AUTHOR("Socionext Inc.");
>
Socionext now is what Fujitsu was when this code was written, so this
addition seems ok.
So may be add it as
MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD., SOCIONEXT INC.");
cheers.
