On 24/10/2022 10:55, Frank Wunderlich wrote: > Hi > >> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx> >> An: "Frank Wunderlich" <linux@xxxxxxxxx>, linux-mediatek@xxxxxxxxxxxxxxxxxxx >> Cc: "Frank Wunderlich" <frank-w@xxxxxxxxxxxxxxx>, "Chaotian Jing" <chaotian.jing@xxxxxxxxxxxx>, "Ulf Hansson" <ulf.hansson@xxxxxxxxxx>, "Rob Herring" <robh+dt@xxxxxxxxxx>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "Wenbin Mei" <wenbin.mei@xxxxxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx >> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 >> >> On 23/10/2022 05:12, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >>> >>> Add SoC specific section for defining clock configuration. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Hi, > > got another config from mtk which requires changing binding a bit > > clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, > <&infracfg CLK_INFRA_MSDC_HCK_CK>, > <&infracfg CLK_INFRA_MSDC_CK>, > <&infracfg CLK_INFRA_MSDC_133M_CK>, > <&infracfg CLK_INFRA_MSDC_66M_CK>; > clock-names = "source", "hclk", "source_cg", "bus_clk", > "sys_cg"; > in binding: > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -241,15 +241,17 @@ allOf: > items: > - description: source clock > - description: HCLK which used for host > - - description: AXI bus clock gate > - - description: AHB bus clock gate > + - description: independent source clock gate > + - description: bus clock used for internal register access (required for MSDC0/3). > + - description: msdc subsys clock gate > clock-names: > minItems: 3 > items: > - const: source > - const: hclk > - - const: axi_cg > - - const: ahb_cg > + - const: "source_cg" > + - const: "bus_clk" > + - const: "sys_cg" > > will send an updated v4...old version was working but i should use the new one. > > @Krzysztof can i take your RB here or should i leave it as Patch was changed? Please drop my tag, so I will re-review it. Thanks! Best regards, Krzysztof
