2022年10月11日 22:41, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Tue, 27 Sept 2022 at 04:04, Weizhao Ouyang <ouyangweizhao@xxxxxxxx> > wrote: > > > > From: Matthew Ma <mahongwei@xxxxxxxx> > > > > SDIO tuple is only allocated for standard SDIO card, especially it > > causes memory corruption issues when the non-standard SDIO card has > > removed since the card device's reference counter does not increase for > > it at sdio_init_func(), but all SDIO card device reference counter has > > decreased at sdio_release_func(). > > > > Fixes: 1a632f8cdc33 ("sdio: split up common and function CIS parsing") > > Signed-off-by: Matthew Ma <mahongwei@xxxxxxxx> > > Reviewed-by: Weizhao Ouyang <ouyangweizhao@xxxxxxxx> > > Reviewed-by: John Wang <wangdayu@xxxxxxxx> > > Apologize for the delay! > > Wow, that's a very old bug you fixed! However, it looks like the fixed > commit should be changed to 6f51be3d37df ("sdio: allow non-standard > SDIO cards"). Thanks, I messed the tag. > > I tried to apply the patch, but the patch format seems to be corrupt. > Did you use git format-patch and did run ./scripts/checkpatch.pl on > it? > Yeah I used checkpatch.pl with strict mode to check this patch, and it has no obvious style problems. What's the format error you got? Thanks, Weizhao