On Mon, Sep 26, 2022 at 10:20:21PM +0300, Adrian Hunter wrote:
> SDHCI_QUIRK_RESET_CMD_DATA_ON_IOS is used by only ENE controllers but can
> be replaced by driver code.
>
> Amend the ENE code to hook the ->set_ios() mmc host operation and do the
> reset there.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
> drivers/mmc/host/sdhci-pci-core.c | 23 ++++++++++++++++++++++-
> drivers/mmc/host/sdhci.c | 8 --------
> drivers/mmc/host/sdhci.h | 2 --
> 3 files changed, 22 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index ed53276f6ad9..63613b3d648f 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -297,6 +297,27 @@ static const struct sdhci_pci_fixes sdhci_ricoh_mmc = {
> SDHCI_QUIRK_MISSING_CAPS
> };
>
> +static void ene_714_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> +{
> + struct sdhci_host *host = mmc_priv(mmc);
> +
> + sdhci_set_ios(mmc, ios);
> +
> + /*
> + * Some (ENE) controllers misbehave on some ios operations,
Nice rewording that you snuck in there. =)
I just realized, after going through the patches that Ulf has already
applied this, but FWIW, the series:
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
