Re: [PATCH v4] regulator: core: Resolve supply name earlier to prevent double-init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 25, 2022 at 01:32:50PM +0200, Marek Szyprowski wrote:

> This patch landed recently in linux next as commit 8a866d527ac0 
> ("regulator: core: Resolve supply name earlier to prevent double-init"). 
> Unfortunately it breaks booting of Samsung Exynos 5800 based Peach-Pi 
> (arch/arm/boot/dts/exynos5800-peach-pi.dts) and Peach-Pit 
> (arch/arm/boot/dts/exynos5420-peach-pit.dts) Chromebooks. The last 
> message in the kernel log is a message about disabling 'vdd_1v2' 
> regulator. This regulator is not used directly, however it is a supply 
> for other critical regulators.

This suggests that supplies are ending up not getting bound.  Could you
perhaps add logging to check that we're attempting to resolve the supply
(in the


+       if ((rdev->supply_name && !rdev->supply) &&
+                       (rdev->constraints->always_on ||
+                        rdev->constraints->boot_on)) {

block)?  I'd also note that it's useful to paste the actual error
messages you're seeing rather than just a description of them.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux