On 12/08/2022 16:33, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Aug 11, 2022 at 2:32 PM Conor Dooley <mail@xxxxxxxxxxx> wrote:
>>
>> From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>>
>> Upgrading dt-schema to v2022.08 brings with it better handling of
>> unevaluatedProperties, exposing a previously undetected missing
>> property in the cadence sdhci dt-binding:
>> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: mmc@20008000: Unevaluated properties are not allowed ('card-detect-delay' was unexpected)
>> From schema: Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>
>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>> ---
>> Should this have a fixes tag? If anything, it'd be
>> Fixes: 84723eec251d ("dt-bindings: mmc: cdns: document Microchip MPFS MMC/SDHCI controller")
>> but idk.
>
> No, the common property 'cd-debounce-delay-ms' should be used instead.
So it's a case of "what's in the dts is wrong so it needs to change"?
For the future, where is the line drawn between "don't break the dts"
& "don't use bad properties"? Only if the property has consumers?
I don't mind, just want to get it right next time ;)
Thanks,
Conor.
