On 07/07/2022 09:30, Johnson Wang wrote: > On Thu, 2022-07-07 at 08:46 +0200, Krzysztof Kozlowski wrote: >> On 07/07/2022 07:47, Johnson Wang wrote: >>> This commit adds dt-binding documentation of mmc for MediaTek >>> MT8188 SoC >>> platform. >>> >>> Signed-off-by: Johnson Wang <johnson.wang@xxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> index 2a2e9fa8c188..3fbf33ad4f7c 100644 >>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> @@ -32,6 +32,9 @@ properties: >>> - items: >>> - const: mediatek,mt8186-mmc >>> - const: mediatek,mt8183-mmc >>> + - items: >>> + - const: mediatek,mt8188-mmc >> >> You duplicate quite a lot. Use enum. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Thanks for you suggestion. > > I will use 'enum' to place this compatible strings. > > Just like this: > - items: > - enum: > - mediatek,mt8186-mmc > - mediatek,mt8188-mmc > - mediatek,mt8192-mmc > - mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > > Moreover, it seems that missing an "items:" between oneOf and enum in > the compatible property. > Is my understanding wrong? I did not propose to remove items, so where are they missing? Not sure what you are asking about... Best regards, Krzysztof
