Hi Krzysztof,
On Tue, Jun 14, 2022 at 3:44 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 13/06/2022 12:56, Brad Larson wrote:
> > From: Brad Larson <blarson@xxxxxxx>
> >
> > Add AMD Pensando common and Elba SoC specific device nodes
> >
> > Signed-off-by: Brad Larson <blarson@xxxxxxx>
>
> Thank you for your patch. There is something to discuss/improve.
>
> > ---
> > arch/arm64/boot/dts/amd/Makefile | 1 +
> > arch/arm64/boot/dts/amd/elba-16core.dtsi | 189 +++++++++++++++++
> > arch/arm64/boot/dts/amd/elba-asic-common.dtsi | 103 ++++++++++
> > arch/arm64/boot/dts/amd/elba-asic.dts | 28 +++
> > arch/arm64/boot/dts/amd/elba-flash-parts.dtsi | 106 ++++++++++
> > arch/arm64/boot/dts/amd/elba.dtsi | 191 ++++++++++++++++++
> > 6 files changed, 618 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/amd/elba-16core.dtsi
> > create mode 100644 arch/arm64/boot/dts/amd/elba-asic-common.dtsi
> > create mode 100644 arch/arm64/boot/dts/amd/elba-asic.dts
> > create mode 100644 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi
> > create mode 100644 arch/arm64/boot/dts/amd/elba.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/amd/Makefile b/arch/arm64/boot/dts/amd/Makefile
> > index 68103a8b0ef5..9bba020fa880 100644
> > --- a/arch/arm64/boot/dts/amd/Makefile
> > +++ b/arch/arm64/boot/dts/amd/Makefile
> > @@ -1,2 +1,3 @@
> > # SPDX-License-Identifier: GPL-2.0
> > dtb-$(CONFIG_ARCH_SEATTLE) += amd-overdrive-rev-b0.dtb amd-overdrive-rev-b1.dtb
> > +dtb-$(CONFIG_ARCH_PENSANDO) += elba-asic.dtb
>
> Put it in alphabetical order, so not at the end of file.
Reversed the order in the Makefile
> (...)
>
> > +
> > +&spi0 {
> > + num-cs = <4>;
> > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>,
> > + <&porta 7 GPIO_ACTIVE_LOW>;
> > + status = "okay";
> > + spi@0 {
>
> Rob's comment about bindings applies here as well, so please fix both.
> This has to be sorted out - either it is SPI controller or MFD.
>
> Rest looks okay for me.
Proposed a change after reviewing existing drivers in mfd directory
Regards,
Brad
