... > >> brq->data.blocks = queue_physical_block_size(req->q) >> SECTOR_SHIFT; > > > > Do we want to switch to SECTOR_SHIFT instead of 9? So far SECTOR_SHIFT is not used at all in mmc > core. > > I guess '9' is more consistent You can just multiply/divide by 512u (probably SECTOR_SIZE). (In some senses 512u is actually better!) More obvious still and the compiler will generate a shift anyway. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)