Hi Krzysztof,
On Thu, Apr 7, 2022 at 12:06 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 07/04/2022 01:36, Brad Larson wrote:
> > Add Pensando common and Elba SoC specific device nodes
> >
> > +&spi0 {
> > + num-cs = <4>;
> > + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>,
> > + <&porta 7 GPIO_ACTIVE_LOW>;
> > + status = "okay";
> > + spi0_cs0@0 {
>
> Generic node name needed matching the class of a devicxe.
The device on this spi bus is a FPGA with 4 functions and looking at
other projects I've changed it to a resource-controller node name. On
cs0 there is a sub-device reset-controller added in the upcoming
patchset to enable hardware reset of the eMMC device.
> > + compatible = "semtech,sx1301"; /* Enable spidev */
>
> This comment is a bit odd... did you just use random compatible from
> spidev instead of defining proper compatible?
Yes, because adding a compatible was nacked. We have a driver added
(two actually, mfd and reset driver) for the next patch update.
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> Why address/size cells?
Removed where not needed
> > + spi-max-frequency = <12000000>;
> > + reg = <0>;
>
> Please put reg just after compatible. It's the most common pattern.
Yes, moved reg to be right after compatible
> > + };
> > +
> > + spi0_cs1@1 {
> > + compatible = "semtech,sx1301";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + spi-max-frequency = <12000000>;
> > + reg = <1>;
> > + };
> > +
(...)
> > +
> > + mssoc: mssoc@307c0000 {
>
> Generic node name.
Changed to syscon
> > + compatible = "syscon", "simple-mfd";
>
> This does not look correct. Syscon is okay, but why do you need
> simple-mfd (there are no children here)?
Yes, removed "simple-mfd"
Regards,
Brad
