On Thu, 2022-05-19 at 13:18 +0200, AngeloGioacchino Del Regno wrote: > Il 19/05/22 13:13, Axe Yang ha scritto: > > Extend interrupts and pinctrls for SDIO wakeup interrupt feature. > > This feature allow SDIO devices alarm asynchronous interrupt to > > host > > even when host stop providing clock to SDIO card. An extra wakeup > > interrupt and pinctrl states for SDIO DAT1 pin state switching are > > required in this scenario. > > > > Signed-off-by: Axe Yang <axe.yang@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/mtk-sd.yaml | 53 > > ++++++++++++++++++- > > 1 file changed, 52 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index 2a2e9fa8c188..b068ab67a054 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -72,12 +72,26 @@ properties: > > - const: ahb_cg > > > > interrupts: > > - maxItems: 1 > > + description: > > + Should at least contain MSDC GIC interrupt. To support SDIO > > in-band wakeup, an extended > > + interrupt is required and be configured as wakeup source > > irq. > > + minItems: 1 > > + maxItems: 2 > > + > > + interrupt-names: > > + items: > > + - const: msdc_irq > > > > That ain't right. You have two interrupts, so you describe two > interrupts: > > interrupt-names: > minItems: 1 > items: > - const: msdc > - const: sdio-wakeup > Fixed in v11. > ...also, I personally don't like the "_irq" suffix: we're specifying > interrupts in > interrupt-names, so it sounds a bit redundant. > > You're free to keep it, if you really like it though. Totally agree with that. The suffix is removed in v11. Regards, Axe
