On 15/04/2022 01:33, Andrew Lunn wrote: > Hi Chris > >> +required: >> + - compatible >> + - reg >> + - interrupts > > https://elixir.bootlin.com/linux/latest/source/drivers/mmc/host/sdhci-dove.c#L78 > > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/dove.dtsi#L344 > > Dove does actually have a clock. It looks like it is optional in the > driver, but the .dtsi file has it. It is not documented in the current > .txt file, so i can understand you missing it. > > I'm surprised the DT tools didn't complain about an unexpected > property. They did. :) It seems binding is a bit out of date, so Chris should extend/update it. Same comments about maintainer as for patch #3. Best regards, Krzysztof
