Re: [PATCH v1] mmc-utils: Add General command CMD56 read support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2022-04-09 at 09:03 +0000, Avri Altman wrote:
> > +       memset(&idata, 0, sizeof(idata));
> > +       idata.write_flag = 0;
> > +       idata.opcode = MMC_GEN_CMD;
> > +       idata.arg = arg;
> Practically arg is not needed, because bits[1..31] are meaningless.
> Maybe just set: idata.arg = 1;
> 
> Thanks,
> Avri
Thanks for your review.

you are right arg is not needed according to eMMC spec.  But as I
mentioned in the commit message, for the universal use. we need it for
the vendor-specific arg. I will change it that its arg will be 1 by
default if the user doesn't specific arg.

Kind regards,
Bean


  




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux