On Sat, Apr 2, 2022 at 3:12 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 02/04/2022 21:39, Adam Ford wrote: > > The SDHC controller in the imx8mn and imx8mp have the same controller > > as the imx8mm which is slightly different than that of the imx7d. > > Using the fallback of the imx8mm enables the controllers to support > > HS400-ES which is not available on the imx7d. After discussion with NXP, > > it turns out that the imx8qm should fall back to the imx8qxp, because > > those have some additional flags not present in the imx8mm. > > > > Suggested-by: haibo.chen@xxxxxxx > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > --- > > V3: Marked the imx7d-usdhc as deprecated when there are better > > fallback options or the fallback isn't needed. > > Leave the deprecated fallback in the YAML to prevent errors > > Remove Reviewed-by from Krzysztof Kozlowski due to the above > > > > V2: Update the table per recomendation from Haibo. > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index 7dbbcae9485c..11f039320d79 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -34,23 +34,34 @@ properties: > > - fsl,imx6ull-usdhc > > - fsl,imx7d-usdhc > > - fsl,imx7ulp-usdhc > > + - fsl,imx8mm-usdhc > > + - fsl,imx8qxp-usdhc > > - fsl,imxrt1050-usdhc > > - nxp,s32g2-usdhc > > - items: > > - enum: > > - fsl,imx8mm-usdhc > > + - fsl,imx8mq-usdhc > > + # fsl,imx7d-usdhc fallback is deprecated for imx8mm-usdhc > > + - const: fsl,imx7d-usdhc > > Instead of comment use (I think on the same level as items): > > deprecated: true I have tried various combinations of where to place "deprecated" and whether or not to use a hyphen, but I always get syntax errors. Do you have an example of this I can see? adam > > > + - items: > > + - enum: > > - fsl,imx8mn-usdhc > > - fsl,imx8mp-usdhc > > So if this is a deprecated list, where is a proper one? The list with > this enum + imx8mm? > > IOW, you need to list here: > 1. Old combinations with "deprecated: true" > 2. New combinations. > > > - - fsl,imx8mq-usdhc > > - - fsl,imx8qm-usdhc > > - - fsl,imx8qxp-usdhc > > + - const: fsl,imx8mm-usdhc > > + # fsl,imx7d-usdhc fallback is deprecated > > - const: fsl,imx7d-usdhc > > - items: > > - enum: > > - - fsl,imx93-usdhc > > - fsl,imx8ulp-usdhc > > + - fsl,imx93-usdhc > > - const: fsl,imx8mm-usdhc > > - > > + - items: > > + - enum: > > + - fsl,imx8qm-usdhc > > + - const: fsl,imx8qxp-usdhc > > + # fsl,imx7d-usdhc fallback is deprecated > > + - const: fsl,imx7d-usdhc > > reg: > > maxItems: 1 > > > > > Best regards, > Krzysztof
