Dear Arnd: > > Hi Tony, > > I love your patch! Yet something to improve: > > [auto build test ERROR on ulf-hansson-mmc-mirror/next] [cannot apply to > robh/for-next linus/master v5.18-rc1 next-20220406] [If your patch is applied > to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/intel-lab-lkp/linux/commits/Tony-Huang/Add-mmc-driver-f > or-Sunplus-SP7021-SOC/20220406-194106 > base: https://git.linaro.org/people/ulf.hansson/mmc-mirror.git next > config: nds32-buildonly-randconfig-r003-20220406 > (https://download.01.org/0day-ci/archive/20220407/202204070029.JvyEor8F-l > kp@xxxxxxxxx/config) > compiler: nds32le-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://github.com/intel-lab-lkp/linux/commit/325a0d9ca9d65f5616f794e0dbb > 04256312f739d > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review > Tony-Huang/Add-mmc-driver-for-Sunplus-SP7021-SOC/20220406-194106 > git checkout 325a0d9ca9d65f5616f794e0dbb04256312f739d > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 > make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/mmc/host/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All error/warnings (new ones prefixed by >>): > > drivers/mmc/host/sunplus-mmc.c: In function 'spmmc_set_bus_timing': > >> drivers/mmc/host/sunplus-mmc.c:311:15: warning: variable > >> 'timing_name' set but not used [-Wunused-but-set-variable] > 311 | char *timing_name; > | ^~~~~~~~~~~ > drivers/mmc/host/sunplus-mmc.c: At top level: > >> drivers/mmc/host/sunplus-mmc.c:798:13: warning: no previous prototype > >> for 'spmmc_irq' [-Wmissing-prototypes] > 798 | irqreturn_t spmmc_irq(int irq, void *dev_id) > | ^~~~~~~~~ > >> drivers/mmc/host/sunplus-mmc.c:894:5: warning: no previous prototype > >> for 'spmmc_get_cd' [-Wmissing-prototypes] > 894 | int spmmc_get_cd(struct mmc_host *mmc) > | ^~~~~~~~~~~~ > drivers/mmc/host/sunplus-mmc.c: In function 'spmmc_drv_probe': > >> drivers/mmc/host/sunplus-mmc.c:1021:22: warning: variable 'mode' set > >> but not used [-Wunused-but-set-variable] > 1021 | unsigned int mode; > | ^~~~ > drivers/mmc/host/sunplus-mmc.c: At top level: > >> drivers/mmc/host/sunplus-mmc.c:1170:9: error: implicit declaration of > >> function 'SYSTEM_SLEEP_PM_OPS'; did you mean > >> 'SET_SYSTEM_SLEEP_PM_OPS'? [-Werror=implicit-function-declaration] > 1170 | SYSTEM_SLEEP_PM_OPS(spmmc_pm_suspend, > spmmc_pm_resume) > | ^~~~~~~~~~~~~~~~~~~ > | SET_SYSTEM_SLEEP_PM_OPS I follow your sugguest in v5. "It's better to use SYSTEM_SLEEP_PM_OPS/RUNTIME_PM_OPS instead of the SET_ version" But kernel test robot shows error.
