On 01/04/2022 04:18, Tinghan Shen wrote: > Hi Matthias, > > On Thu, 2022-03-31 at 12:54 +0200, Matthias Brugger wrote: >> >> On 30/03/2022 11:45, Tinghan Shen wrote: >>> MediaTek has a new version of mmc IP since mt8183. Some IO registers >>> are moved to top to improve hardware design and named as "host top >>> registers". >>> >>> Add host top register in the reg binding description for mt8183 and >>> successors. >>> >>> Signed-off-by: Wenbin Mei <wenbin.mei@xxxxxxxxxxxx> >>> Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 15 ++++++++++++++- >>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> index 297ada03e3de..2a2e9fa8c188 100644 >>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml >>> @@ -40,7 +40,10 @@ properties: >>> - const: mediatek,mt8183-mmc >>> >>> reg: >>> - maxItems: 1 >>> + minItems: 1 >> >> From my understanding adding minItems is correct, but you need to add also >> maxItems: 2 as there can't be more then two register entries. >> >> Regards, >> Matthias >> > > After add "maxItems: 2", I get following message when doing dt_binding_check. > from this message, it looks like that maxItems is not necessary. That's correct, you don't need them because "items" defines it. Best regards, Krzysztof
