On Mon, Mar 28, 2022 at 2:20 AM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote: > > Hello Adam, > > On 27.03.22 14:38, Adam Ford wrote: > > The SDHC controller in the imx8mp has the same controller > > as the imx8mm which supports HS400-ES. Change the compatible > > fallback to imx8mm to enable it. > > I believe that's a shortcoming of the Linux driver, which should explicitly list > fsl,imx8mp-usdhc in its compatibles and enable HS400-ES for it. > > I find dropping compatibles problematic, because like Linux matching > fsl,imx8mm-usdhc, but not fsl,imx8mp-usdhc, other software may match > fsl,imx7d-usdhc, but not fsl,imx8[mp]-usdhc. > > I'd prefer that either the kernel driver gains extra compatibles or that > the DTS lists extra compatibles and we refrain from dropping existing > (correct) ones. > I would argue that imx7d is not correct since the IP blocks between imx7d and imx8mm have different flags/quirks. One of which includes HS400-ES, but there are other differences as well. > What do you think?
