On Fri, 25 Mar 2022 at 04:54, Lai Jason <jasonlai.genesyslogic@xxxxxxxxx> wrote: > > On Thu, Mar 24, 2022 at 6:50 PM AKASHI Takahiro > <takahiro.akashi@xxxxxxxxxx> wrote: > > > > On Thu, Mar 24, 2022 at 11:22:16AM +0100, Ulf Hansson wrote: > > > On Thu, 24 Mar 2022 at 02:29, AKASHI Takahiro > > > <takahiro.akashi@xxxxxxxxxx> wrote: > > > > > > > > On Wed, Mar 23, 2022 at 05:15:59PM +0100, Ulf Hansson wrote: > > > > > On Tue, 22 Feb 2022 at 04:40, Jason Lai <jasonlai.genesyslogic@xxxxxxxxx> wrote: > > > > > > > > > > > > From: Jason Lai <jason.lai@xxxxxxxxxxxxxxxxxxx> > > > > > > > > > > > > UHS-II card initialization flow is divided into 2 categories: PHY & Card. > > > > > > Part 1 - PHY Initialization: > > > > > > Every host controller may need their own private operation to > > > > > > establish LINK between controller and card. So we add a new member > > > > > > function(uhs2_detect_init) in struct mmc_host_ops for host > > > > > > controller use. > > > > > > Part 2 - Card Initialization: > > > > > > This part can be divided into 6 substeps. > > > > > > 1. Send UHS-II CCMD DEVICE_INIT to card. > > > > > > 2. Send UHS-II CCMD ENUMERATE to card. > > > > > > 3. Send UHS-II Native Read CCMD to obtain capabilities in CFG_REG > > > > > > of card. > > > > > > 4. Host compares capabilities of host controller and card, then > > > > > > write the negotiated values to Setting field in CFG_REG of card > > > > > > through UHS-II Native Write CCMD. > > > > > > 5. Switch host controller's clock to Range B if it is supported by > > > > > > both host controller and card. > > > > > > 6. Execute legacy SD initialization flow. > > > > > > Part 3 - Provide a function to transform legacy SD command packet into > > > > > > UHS-II SD-TRAN DCMD packet. > > > > > > > > > > > > Most of the code added above came from Intel's original patch[3]. > > > > > > > > > > > > [3] > > > > > > https://patchwork.kernel.org/project/linux-mmc/patch/1419672479-30852-2- > > > > > > git-send-email-yi.y.sun@xxxxxxxxx/ > > > > > > > > To honor the original work, we should add Intel's copyright notice here > > > > as I did before. > > > > > > I think Jason already did, at least for some of the files in this series. > > > > > > Note also that, the initial code that was posted, is very far from > > > what code that is going to be merged. Simply because the quality was > > > very poor and not acceptable for the upstream kernel. > > > > I don't think so. > > I don't see much difference from my modified version[1] which is also > > based on Intel's original work. > > > > [1] https://www.spinics.net/lists/linux-mmc/msg57321.html > > > > I agree with most of what Takahiro said. The data structure and command > packet for UHS-II followed Intel's original work. But Intel's original work > cannot actually work. UHS-II SD card was supported successfully after Ben > and Takahiro's hard working on patch set [RFC V3.1] Add support UHS-II for > GL9755: https://patchwork.kernel.org/project/linux-mmc/list/?series=378627&archive=both > > In my opinion, keeping Intel's copyright information at head of sd_uhs2.c and > sd_uhs2.h like listed below is a good idea. What do you think? I have no problem with that. However, I have to admit that I still think we have some more work to do with the patches, before I am ready to queue them. In other words, the decision is probably best taken a bit further down the road. Note also that we have other ways of giving companies/people credit, without using the copyright thing. Like the co-developed by tag and mentioning companies/people in file-headers and commit messages, for example. > > // SPDX-License-Identifier: GPL-2.0-or-later > /* > * linux/drivers/mmc/core/uhs2.c - UHS-II driver > * > * Copyright (C) 2020 Linaro Limited > * Author: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > * Copyright (C) 2014 Intel Corp, All Rights Reserved. > * Copyright (C) 2020 Genesys Logic, Inc. > * Authors: Ben Chuang <ben.chuang@xxxxxxxxxxxxxxxxxxx> > * Authors: Jason Lai <jason.lai@xxxxxxxxxxxxxxxxxxx> > * Copyright (C) 2020 Linaro Limited > * Author: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> > */ > > kind regards, > Jason Lai [...] Kind regards Uffe
