On Wed, Mar 23, 2022 at 8:56 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 23/03/2022 14:40, Adam Ford wrote: > > The SDHC controller in the imx8mn and imx8mp have the same controller > > as the imx8mm which is slightly different than that of the imx7d. > > Using the fallback of the imx8mm enables the controllers to support > > HS400-ES which is not available on the imx7d. > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > index 7dbbcae9485c..d6ea73d76bdd 100644 > > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > @@ -39,14 +39,14 @@ properties: > > - items: > > - enum: > > - fsl,imx8mm-usdhc > > Your change looks reasonable, but why imx8mm is compatible with imx7d? I saw that, and I wasn't sure the best way to go about fixing it. If I move the 8mm out of the imx7d category, do I need to add it to the enum list associated with the imx8mm, or can I just delete it from the enum leaving the const for imx8mm good enough? I am not very good with YAML files yet, so please forgive my ignorance. adam > > > - - fsl,imx8mn-usdhc > > - - fsl,imx8mp-usdhc > > - fsl,imx8mq-usdhc > > - fsl,imx8qm-usdhc > > - fsl,imx8qxp-usdhc > > - const: fsl,imx7d-usdhc > > - items: > > - enum: > > + - fsl,imx8mn-usdhc > > + - fsl,imx8mp-usdhc > > - fsl,imx93-usdhc > > - fsl,imx8ulp-usdhc > > - const: fsl,imx8mm-usdhc > > > Best regards, > Krzysztof
