Hi Peter,
在 2022/3/1 6:36, Peter Geis 写道:
The dw_mmc-rockchip driver drops a large amound of logspam constantly
when the cd-broken flag is enabled.
Set the warning to be debug ratelimited in this case.
May I know which platform did you use?
Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
---
drivers/mmc/host/dw_mmc-rockchip.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index 95d0ec0f5f3a..d0ebf0afa42a 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -50,8 +50,13 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios)
cclkin = ios->clock * RK3288_CLKGEN_DIV;
ret = clk_set_rate(host->ciu_clk, cclkin);
- if (ret)
- dev_warn(host->dev, "failed to set rate %uHz\n", ios->clock);
+ if (ret) {
+ /* this screams when card detection is broken */
+ if (host->slot->mmc->caps & MMC_CAP_NEEDS_POLL)
+ dev_dbg_ratelimited(host->dev, "failed to set rate %uHz\n", ios->clock);
+ else
+ dev_warn(host->dev, "failed to set rate %uHz\n", ios->clock);
+ }
bus_hz = clk_get_rate(host->ciu_clk) / RK3288_CLKGEN_DIV;
if (bus_hz != host->bus_hz) {
