On Tue, 18 Jan 2022 at 13:44, Jason Lai <jasonlai.genesyslogic@xxxxxxxxx> wrote: > > Series [1] that has been posted by Ulf Hansson which provided some guidance > and an overall structure. > > Series [2] focused on UHS-II card control side to address Ulf's intention > regarding to "modularising" sd_uhs2.c. > > Series [3] is based on series [2] and adopt most of Ulf's comments. > > This series is the successor version of post [3], which adopts Ulf's > comments about series [3]: > 1. Remove unnecessary debug print. > 2. Rephrase description about uhs2_cmd_assemble() in sd_uhs2.c > 3. Place UHS-II variables in the appropriate structure. > 4. Integrate 5 callback functions in host->uhs2_host_operation(). > > Kind regards > Jason Lai Hi Jason, I have looked through the series, but I again find it a bit difficult to review, sorry. I couldn't apply the patches to my next branch (so I fixed that manually), the patches don't build and I get a lot of checkpatch errors/warnings. I tried to help out and worked on fixing these issues and to improve the series. However in the end it turned out to be more work than expected and time I don't have at the moment. To move forward, may I suggest rebasing the series on top of my latest next branch, run checkpatch and make sure it doesn't give errors/warnings, then of course you also need to make sure that each patch can be compiled. Then we can take it from there. Kind regards Uffe > > [1] > https://patchwork.kernel.org/project/linux-mmc/list/?series=438509 > > [2] > https://patchwork.kernel.org/project/linux-mmc/list/?series=539737 > > [3] > https://patchwork.kernel.org/project/linux-mmc/list/?series=589827 > > Jason Lai (3): > mmc: add UHS-II related definitions in headers > mmc: Implement content of UHS-II card initialization functions > mmc: core: Support UHS-II card access > > Ulf Hansson (4): > mmc: core: Cleanup printing of speed mode at card insertion > mmc: core: Prepare to support SD UHS-II cards > mmc: core: Announce successful insertion of an SD UHS-II card > mmc: core: Extend support for mmc regulators with a vqmmc2 > > drivers/mmc/core/Makefile | 2 +- > drivers/mmc/core/bus.c | 38 +- > drivers/mmc/core/core.c | 43 +- > drivers/mmc/core/core.h | 1 + > drivers/mmc/core/host.h | 4 + > drivers/mmc/core/regulator.c | 34 ++ > drivers/mmc/core/sd_uhs2.c | 1113 ++++++++++++++++++++++++++++++++++ > include/linux/mmc/card.h | 35 ++ > include/linux/mmc/core.h | 1 + > include/linux/mmc/host.h | 68 +++ > 10 files changed, 1319 insertions(+), 20 deletions(-) > create mode 100644 drivers/mmc/core/sd_uhs2.c > > -- > 2.34.0 >
