On Fri, 7 Jan 2022 at 17:43, Paul Cercueil <paul@xxxxxxxxxxxxxxx> wrote: > > > > Le ven., janv. 7 2022 at 17:33:04 +0100, Ulf Hansson > <ulf.hansson@xxxxxxxxxx> a écrit : > > On Wed, 5 Jan 2022 at 19:30, Paul Cercueil <paul@xxxxxxxxxxxxxxx> > > wrote: > >> > >> These macros are defined conditionally, according to CONFIG_PM: > >> - if CONFIG_PM is enabled, these macros resolve to > >> DEFINE_SIMPLE_DEV_PM_OPS(), and the dev_pm_ops symbol will be > >> exported. > >> > >> - if CONFIG_PM is disabled, these macros will result in a dummy > >> static > >> dev_pm_ops to be created with the __maybe_unused flag. The > >> dev_pm_ops > >> will then be discarded by the compiler, along with the provided > >> callback functions if they are not used anywhere else. > >> > >> In the second case, the symbol is not exported, which should be > >> perfectly fine - users of the symbol should all use the pm_ptr() or > >> pm_sleep_ptr() macro, so the dev_pm_ops marked as "extern" in the > >> client's code will never be accessed. > > > > How common is it to export the dev_pm_ops? Do we really need a macro > > for this? > > $ rgrep EXPORT_SYMBOL drivers/ |grep pm_ops |wc -l > 44 > > That should be enough to justify a macro. Yep, certainly! I will take a closer look beginning next week. [...] Kind regards Uffe
