On 12/24/21 8:35 PM, Martin Blumenstingl wrote: >> The driver overrides the error codes and IRQ0 returned by platform_get_irq() >> to -EINVAL, so if it returns -EPROBE_DEFER, the driver will fail the probe >> permanently instead of the deferred probing. Switch to propagating the error >> codes upstream. IRQ0 is no longer returned by platform_get_irq(), so we now >> can safely ignore it... >> >> Fixes: cbcaac6d7dd2 ("mmc: meson-gx-mmc: Fix platform_get_irq's error checking >> ") > I suggest putting the ") on the previous line. Most "Fixes" tag I have > seen don't use any line-break at all, even if the line gets long. Sorry, was a cut & paste artifact that I didn't notice... :-/ >> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx> > with above comment addressed you can add my: > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Thank you! > Best regards, > Martin > MBR, Sergey