Re: [PATCH v4 3/3] mmc: Add driver for LiteX's LiteSDCard interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 12 Dec 2021 at 16:21, Gabriel L. Somlo <gsomlo@xxxxxxxxx> wrote:
>
> Hi Joel,
>
> On Fri, Dec 10, 2021 at 09:54:30AM -0500, Gabriel Somlo wrote:
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> >
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> >
> > Co-developed-by: Kamil Rakoczy <krakoczy@xxxxxxxxxxxx>
> > Signed-off-by: Kamil Rakoczy <krakoczy@xxxxxxxxxxxx>
> > Co-developed-by: Maciej Dudek <mdudek@xxxxxxxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Maciej Dudek <mdudek@xxxxxxxxxxxxxxxxxxxxxxxx>
> > Co-developed-by: Paul Mackerras <paulus@xxxxxxxxxx>
> > Signed-off-by: Paul Mackerras <paulus@xxxxxxxxxx>
> > Signed-off-by: Gabriel Somlo <gsomlo@xxxxxxxxx>


> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 5af8494c31b5..c1b66d06d1c9 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1093,3 +1093,12 @@ config MMC_OWL
> >
> >  config MMC_SDHCI_EXTERNAL_DMA
> >       bool
> > +
> > +config MMC_LITEX
> > +     tristate "LiteX MMC Host Controller support"
>
> I remembered I still owe you an answer on whether this was ever
> successfully tested as a module: The answer is *yes* -- if configured
> as a loadable module, it loads OK with modprobe, works fine, and can
> be unloaded (with `modprobe -r`) and re-loaded indefinitely.

Very good.

Thanks for following up on the suggestions I made.

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

Cheers,

Joel



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux