Hi Randy,
Thanks for the feedback!
On Sat, Dec 04, 2021 at 12:57:32PM -0800, Randy Dunlap wrote:
> Hi Gabriel--
>
> On 12/4/21 12:41, Gabriel Somlo wrote:
> > +MODULE_DESCRIPTION("LiteX SDCard driver");
> > +MODULE_AUTHOR("Antmicro <www.antmicro.com>");
>
> Admittedly it's not documented, but we would prefer to have some contact info
> in MODULE_AUTHOR(), like an email address or a person's name.
>
> <linux/module.h> says:
>
> /*
> * Author(s), use "Name <email>" or just "Name", for multiple
> * authors use multiple MODULE_AUTHOR() statements/lines.
> */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
OK, so my plan is to add the following MODULE_AUTHOR() statements:
MODULE_AUTHOR("Antmicro <contact@xxxxxxxxxxxx>");
MODULE_AUTHOR("Kamil Rakoczy <krakoczy@xxxxxxxxxxxx>");
MODULE_AUTHOR("Maciej Dudek <mdudek@xxxxxxxxxxxxxxxxxxxxxxxx>");
MODULE_AUTHOR("Paul Mackerras <paulus@xxxxxxxxxx>");
MODULE_AUTHOR("Gabriel Somlo <gsomlo@xxxxxxxxx>");
Antmicro folks: Kamil, Maciej, Mateusz, Karol: I'm not exactly clear
on how you all prefer to be credited but I could either:
1. leave just the first line for Antmicro-the-company, with the
"contact@..." email instead of the website URL, or
2. leave just the developer lines (Kamil and Maciej), or
3. leave all three lines as currently shown above.
I'll queue that up for v3, once I hear back from you.
> > +MODULE_LICENSE("GPL v2");
>
>
> Also, it's up to the MMC maintainer (Ulf), but the function signature
> style that is used in this driver is not the preferred style.
>
> E.g.:
>
> +static int
> +litex_set_bus_width(struct litex_mmc_host *host)
> +{
>
> should be
>
> +static int litex_set_bus_width(struct litex_mmc_host *host)
> +{
Done, and also queued up for v3.
Thanks again,
--Gabriel
