Hi, > > This patch also fixes a compile error with a newer version of GCC: > error: '__builtin_strncpy' output may be truncated copying 8 bytes from a > string of length 511 [-Werror=stringop-truncation] You are reverting commit 0eea71e4f2 (mmc-utils: Fix for Firmware Version string printing). Please use git revert and add an explanation in your commit log. You might also would like to take a look at the correspondence concerning a different approach to the same issue here - https://lore.kernel.org/lkml/20211114204331.39555-2-huobean@xxxxxxxxx/ Thanks, Avri > > Signed-off-by: Oleh Kravchenko <oleg@xxxxxxxxxx> > Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx> > --- > mmc_cmds.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > PATCH v4 > Update commit message. > > diff --git a/mmc_cmds.c b/mmc_cmds.c > index 73bd32a..e07ec94 100644 > --- a/mmc_cmds.c > +++ b/mmc_cmds.c > @@ -1392,7 +1392,6 @@ int do_read_extcsd(int nargs, char **argv) > __u32 regl; > int fd, ret; > char *device; > - char lbuf[10]; > const char *str; > > if (nargs != 2) { > @@ -1834,9 +1833,7 @@ int do_read_extcsd(int nargs, char **argv) > } > > if (ext_csd_rev >= 7) { > - memset(lbuf, 0, sizeof(lbuf)); > - strncpy(lbuf, (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION], 8); > - printf("eMMC Firmware Version: %s\n", lbuf); > + printf("eMMC Firmware Version: %.8s\n", > + (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]); > printf("eMMC Life Time Estimation A > [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]: 0x%02x\n", > ext_csd[EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_A]); > printf("eMMC Life Time Estimation B > [EXT_CSD_DEVICE_LIFE_TIME_EST_TYP_B]: 0x%02x\n", > -- > 2.32.0
