Re: [PATCH v3] mmc: dw_mmc: Allow lower TMOUT value than maximum

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 Nov 2021 at 17:59, Marten Lindahl <martenli@xxxxxxxx> wrote:
>
> On Mon, Nov 15, 2021 at 03:54:19PM +0100, Ulf Hansson wrote:
> > On Wed, 10 Nov 2021 at 12:05, Mårten Lindahl <marten.lindahl@xxxxxxxx> wrote:
> > >
> > > The TMOUT register is always set with a full value for every transfer,
> > > which (with a 200MHz clock) will give a full DRTO of ~84 milliseconds.
> > > Since the software dto_timer acts as a backup in cases when this timeout
> > > is not long enough, it is normally not a problem. But setting a full
> > > value makes it impossible to test shorter timeouts, when for example
> > > testing data read times on different SD cards.
> > >
> > > Add a function to set any value smaller than the maximum of 0xFFFFFF.
> > >
> > > Signed-off-by: Mårten Lindahl <marten.lindahl@xxxxxxxx>
> >
> > Applied for next, thanks!
> >
> > Kind regards
> > Uffe
> >
>
> Hi Ulf!
>
> During tests on some units I found that there is a potential overflow
> of the 32bit divider in this patch (if clk_div > 4).
>
> Is it possible to stop this patch, until I created a new version of it?
> I guess it's better to update this patch, in favour of sending a new
> correction patch for it?

I have dropped the patch from my next branch. Please send a v4.

[...]

Kind regards
Uffe




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux