On Mon, Nov 15, 2021 at 02:24:40PM -0800, Brad Larson wrote: > Hi Sergey, > > On Thu, Oct 28, 2021 at 12:49 AM Serge Semin <fancer.lancer@xxxxxxxxx> wrote: > > > > On Sun, Oct 24, 2021 at 06:51:50PM -0700, Brad Larson wrote: > > > The Pensando Elba SoC has integrated the DW APB SPI Controller > > > > Please add the "dt-bindings: " prefix to the patch name and discard > > the word "bindings" from the title as the submitting DT-patches > > requires: > > Documentation/devicetree/bindings/submitting-patches.rst > > I'll add that. I recall looking at the recent git log for similar > changes to the file as the current recommended approach. > > > > > > > Signed-off-by: Brad Larson <brad@xxxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > index d7e08b03e204..0b5ebb2ae6e7 100644 > > > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > > > @@ -73,6 +73,8 @@ properties: > > > - renesas,r9a06g032-spi # RZ/N1D > > > - renesas,r9a06g033-spi # RZ/N1S > > > - const: renesas,rzn1-spi # RZ/N1 > > > > > + - description: Pensando Elba SoC SPI Controller > > > + const: pensando,elba-spi > > > > AFAICS from the driver-part of the patchset it's not enough. You've > > also got the syscon phandle, which needs to be reflected in the > > bindings. That also makes me thinking that you didn't perform the > > "dtbs_check" on the dts-files you were going to submit, but for some > > reason discarded from this series (btw why?). If you did you would > > have got an error of an unevaluated property detection. > > I ran the checks below and didn't get errors. Rob provided some info > and I found the server did not have yamllint installed (not flagged by > tool). Also dt-schema was not the latest. I'm re-doing this and > including "DT_CHECKER_FLAGS=-m" as that is new with v5.13. > > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make ARCH=arm64 dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/pensando,elba.yaml Hmm, that's weird. Rob, does dtschema tool have the "unevaluatedProperties" property support? Brad, anyway you still need to add the syscon-property (pensando,*spics) requirement in the snps,dw-apb-ssi.yaml schema. See the way it's done there for instance for "baikal,bt1-sys-ssi" when it comes to the vendor-specific properties definition in the allOf composition block. You'll need to define a custom phandle property there in case if a DT-node is compatible with you SPI controller. -Sergey > > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/vendor-prefixes.yaml > make dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/pensando,elba.yaml > > Thanks > Brad
