> Am 08.11.2021 um 16:34 schrieb Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>: > > On Monday 8 November 2021 16:00:02 CET Ulf Hansson wrote: >> On Sat, 6 Nov 2021 at 15:31, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> wrote: >>> >>> Hi Jérôme, >>> >>>> Am 05.11.2021 um 15:27 schrieb Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>: >>>> >>>> On Friday 5 November 2021 10:05:47 CET H. Nikolaus Schaller wrote: >>>>> From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> >>>>> >>>>> MMC subsystem provides a way to apply quirks when a device match some >>>>> properties (VID, PID, etc...) Unfortunately, some SDIO devices does not >>>>> comply with the SDIO specification and does not provide reliable VID/PID >>>>> (eg. Silabs WF200). >>>>> >>>>> So, the drivers for these devices rely on device tree to identify the >>>>> device. >>>>> >>>>> This patch allows the MMC to also rely on the device tree to apply a >>>>> quirk. >>>>> >>>>> Signed-off-by: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx> > > [...] > >>>>> --- >>>>> drivers/mmc/core/card.h | 3 +++ >>>>> drivers/mmc/core/quirks.h | 17 +++++++++++++++++ >>>>> 2 files changed, 20 insertions(+) >>>>> >>>>> +static inline bool mmc_fixup_of_compatible_match(struct mmc_card *card, >>>>> + const char *const *compat_list) >> >> After a second thought, I am not sure we really need a list of >> compatibles here. The quirks we may want to apply should be specific >> per device and most likely not shared among a family of devices, don't >> you think? > > Indeed. I dislike to have to declare a list of compatible device (see > wl1251_compatible_list in patch 5) outside of the fixup list. > > If I have several devices, I prefer to copy-paste a few lines in the > mmc_fixup list (for the WFX driver, I have 4 devices to declare). Agreed. It makes the macro easier to use. BR and thanks, Nikolaus
