On Thu, Sep 30, 2021 at 1:58 AM Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > Let's add compatible values for the legacy SoCs so we can continue > deprecating omap_hsmmc in favor of sdhci-omap driver. > > For omap5, we want to have a separate compatible from omap4 for the > additional features available on omap5. AFAIK ti81 can just use the > omap4 compatible. > > Cc: devicetree@xxxxxxxxxxxxxxx > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> Tony, I noticed that you added omap3 compatibility to the driver and the bindings, but no device tree changes for omap3.dtsi to enable this. Is there anything holding back? I modified omap3.dtsi and changed the compatible flag to ti,omap3-sdhci and it boots from SD card just fine. For some reason, I cannot get the wl1283 to function, but the driver probes, so I need to spend some time investigating this. If i can get my wl1283 working again, I'll reply with a tested note. I hope to have more time tomorrow, but i can't do it any more today. adam > --- > Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > @@ -5,7 +5,11 @@ Refer to mmc.txt for standard MMC bindings. > For UHS devices which require tuning, the device tree should have a "cpu_thermal" node which maps to the appropriate thermal zone. This is used to get the temperature of the zone during tuning. > > Required properties: > -- compatible: Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers > +- compatible: Should be "ti,omap2430-sdhci" for omap2430 controllers > + Should be "ti,omap3-sdhci" for omap3 controllers > + Should be "ti,omap4-sdhci" for omap4 and ti81 controllers > + Should be "ti,omap5-sdhci" for omap5 controllers > + Should be "ti,dra7-sdhci" for DRA7 and DRA72 controllers > Should be "ti,k2g-sdhci" for K2G > Should be "ti,am335-sdhci" for am335x controllers > Should be "ti,am437-sdhci" for am437x controllers > -- > 2.33.0
