On Thu, 9 Sept 2021 at 15:03, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > Hi Ulf, > > > > 1) despite not being mentioned in the spec, do we want to allow CMD12 to > > > abort tuning for SD as well? > > > > It sounds like we should give it a try with the CMD12 command for SD > > cards as well. > > I think so. > > > > 2) If so, how to make sure not apply it to SDIO but SD only? > > > > For now, I am fine with adding a new bus_ops callback > > (->abort_tuning()) and then let mmc_send_abort_tuning() to call it. > > Cool, I like that approach. > > > I have some additional plans to improve life cycle issues for the > > bus_ops, but let's ignore that for now. I can deal with that later. > > Ok, good. > > > That said, mmc_send_abort_tuning() should no longer need to take the > > opcode as an in-parameter, thus some additional cleanup should be > > needed in a few host drivers because of that. > > > > Would that work? > > I think that would work nicely. I will have a go with the above approach > and come back then. Or do you want to implement it? Please go ahead, I can review it. > > Thanks and happy hacking, > > Wolfram > Kind regards Uffe
