Hi Brad,
On Mon, Aug 23, 2021 at 3:14 AM Brad Larson <brad@xxxxxxxxxxx> wrote:
> On Mon, Mar 29, 2021 at 3:40 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> >
> > On Mon, Mar 29, 2021 at 4:19 AM Brad Larson <brad@xxxxxxxxxxx> wrote:
> > > On Sun, Mar 7, 2021 at 11:21 AM Andy Shevchenko
> > > <andy.shevchenko@xxxxxxxxx> wrote:
> > > > On Thu, Mar 4, 2021 at 4:40 PM Brad Larson <brad@xxxxxxxxxxx> wrote:
> >
> > ...
> >
> > > > > +config GPIO_ELBA_SPICS
> > > > > + bool "Pensando Elba SPI chip-select"
> > > >
> > > > Can't it be a module? Why?
> > >
> > > All Elba SoC based platforms require this driver to be built-in to boot and
> > > removing the module would result in a variety of exceptions/errors.
> >
> > Needs to be at least in the commit message.
> >
> > > > > + depends on ARCH_PENSANDO_ELBA_SOC
> > > > > + help
> > > > > + Say yes here to support the Pensndo Elba SoC SPI chip-select driver
Pensando
> > > >
> > > > Please give more explanation what it is and why users might need it,
> > > > and also tell users how the module will be named (if there is no
> > > > strong argument why it can't be a module).
> > > >
> > > Fixed the typo.
> >
> > Yeah, according to the above, you better elaborate what this module is
> > and why people would need it.
> > Also can be a good hint to add
> > default ARCH_MY_COOL_PLATFORM
>
> Regarding the above module question and Kconfig definition, since I
> first looked at this and reviewed the comments I realized I should be
> using builtin. The file gpio/Kconfig is currently this
>
> config GPIO_ELBA_SPICS
> def_bool y
> depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
That means the driver will default to yes by merely enabling
COMPILE_TEST, which is a no-go.
config GPIO_ELBA_SPICS
bool "one-line summary"
depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
default y if ARCH_PENSANDO_ELBA_SOC
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
