Hi Elliott,
On Thu, Mar 4, 2021 at 12:44 PM Elliott, Robert (Servers)
<elliott@xxxxxxx> wrote:
[...]
> > +config GPIO_ELBA_SPICS
> > + bool "Pensando Elba SPI chip-select"
> > + depends on ARCH_PENSANDO_ELBA_SOC
> > + help
> > + Say yes here to support the Pensndo Elba SoC SPI chip-select
> > driver
>
> Pensndo should be Pensando
Fixed the typo, thanks.
> > diff --git a/drivers/gpio/gpio-elba-spics.c b/drivers/gpio/gpio-elba-spics.c
> > + * Pensando Elba ASIC SPI chip select driver
> ...
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("Elba SPI chip-select driver");
>
> I think it's conventional to include the company name there, so
> start that with "Pensando Elba"
Ok, thanks. BTW I deleted these lines as I should have used
builtin_platform_driver() and not a loadable module.
> Also, "SoC" and "ASIC" are sometimes included after Elba, but sometimes
> are not. Consistency might be helpful.
>
> > +static const struct of_device_id ebla_spics_of_match[] = {
> ...
> > + .of_match_table = ebla_spics_of_match,
>
> ebla should be elba
Fixed the typo and using SoC which is more accurate.
Regards,
Brad
