On Thu, 8 Jul 2021 at 14:50, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Thu, Jul 8, 2021 at 3:33 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Wed, 23 Jun 2021 at 12:17, Andy Shevchenko > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > ... > > > This certainly is an improvement. > > > > Although, what do you think of moving to readx_poll_timeout(), that > > should allow even a better cleanup, don't you think? > > I believe you meant rather read_poll_timeout(). Either way I don't see > the benefit of using that macro when you have to customize its body a > lot. Besides that the macro doesn't use cond_sched() or even > schedule() and I'm not sure it will be an equivalent change. > > That said, I prefer going this patch as is for the time being. We may > adjust it later on. Okay, no strong opinion from my side. Queued for v5.15 on my devel branch, thanks! Kind regards Uffe
