On Fri, 2 Jul 2021 at 08:58, Jason Lai <jasonlai.genesyslogic@xxxxxxxxx> wrote: > > Hi Ulf, > You added one bit definition 'MMC_CAP2_SD_UHS2' in struct mmc_host.caps2. > But there already had a bit definition 'MMC_CAP_UHS2' in struct mmc_host.caps. > #define MMC_CAP_UHS2 (1 << 26) /* Host supports UHS2 mode */ > > This bit was first appearred in [RFC PATCH V3 01/21] mmc: add UHS-II related definitions in public headers. > These 2 bits seems to be defined for the same purpose, which one should I use? The series that $subject patch is part of isn't based on any other UHS-II series that has been posted. Its main goal is to put the foundation in place for the mmc core to support UHS-II, but more developments are certainly needed on top. Moreover, Akashi-san posted another version of the series [1] you are referring to, which should be rebased on top of my series. But that's not sufficient, as additional changes is needed to make this play, I suppose you already knew that. > > kindly regards, > Jason Lai [...] Kind regards Uffe [1] https://patchwork.kernel.org/project/linux-mmc/cover/20201106022726.19831-1-takahiro.akashi@xxxxxxxxxx/
