Re: [PATCH 2/3] mmc: mmci: Implement .hw_reset() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 30 Jun 2021 at 02:32, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Jun 29, 2021 at 1:47 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
>
> > > +static void mmci_hw_reset(struct mmc_host *mmc)
> > > +{
> > > +       struct mmci_host *host = mmc_priv(mmc);
> > > +
> > > +       reset_control_assert(host->rst);
> > > +       udelay(2);
> > > +       reset_control_deassert(host->rst);
> > > +}
> >
> > Unfortunately, this is not the purpose of the ->hw_reset() ops.
> > Instead, it's supposed to be used to make a HW reset of the card, not
> > the controller.
>
> OK I see, let's skip this patch.
>
> I think patch 1 & 3 should be fine though?

Yes. I have a minor comment on patch 1 though.

Kind regards
Uffe



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux