On Tue, 15 Jun 2021 11:00:33 +0800, Wenbin Mei wrote: > MT8195 mmc host IP is compatible with MT8183, and currently it shows: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which means the compatible string in the device tree would be: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8195-mmc", > "mediatek,mt8183-mmc"; > The bindings is wrong and that isn't the result we want. > instead we want: > properties: > compatible: > oneOf: > ... > - items: > - const: mediatek,mt8192-mmc > - const: mediatek,mt8183-mmc > - items: > - const: mediatek,mt8195-mmc > - const: mediatek,mt8183-mmc > which would give us: > compatible = "mediatek,mt8192-mmc", "mediatek,mt8183-mmc"; > and > compatible = "mediatek,mt8195-mmc", "mediatek,mt8183-mmc"; > > Fixes: eb9cb7227e5c (dt-bindings: mmc: Add compatible for Mediatek MT8195) > Signed-off-by: Wenbin Mei <wenbin.mei@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@xxxxxxxxxx>
