Re: [PATCH 2/2] mmc: switch to blk_mq_alloc_disk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christoph,

On 21.06.2021 08:59, Christoph Hellwig wrote:
> On Mon, Jun 21, 2021 at 08:22:07AM +0200, Marek Szyprowski wrote:
>> On 16.06.2021 07:39, Christoph Hellwig wrote:
>>> Use the blk_mq_alloc_disk to allocate the request_queue and gendisk
>>> together.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>> This patch landed recently in linux-next as commit 281ea6a5bfdc ("mmc:
>> switch to blk_mq_alloc_disk"). It triggers the following warning during
>> boot on all my systems with MMC devices:
> Please try this, I lost this hunk in the final cleanup, sorry:

No problem. Right, it fixes the issue. Feel free to add:

Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index e7f89cbf9232..9890a1532cb0 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2331,6 +2331,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
>   	md->queue.blkdata = md;
>   
>   	md->disk->major	= MMC_BLOCK_MAJOR;
> +	md->disk->minors = perdev_minors;
>   	md->disk->first_minor = devidx * perdev_minors;
>   	md->disk->fops = &mmc_bdops;
>   	md->disk->private_data = md;
>
Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux