Hi Shawn, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.13-rc5 next-20210607] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shawn-Lin/mmc-block-Use-card_busy-to-detect-busy-state-in-card_busy_detect/20210607-172028 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 614124bea77e452aa6df7a8714e8bc820b489922 config: x86_64-randconfig-a002-20210607 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project ae973380c5f6be77ce395022be40350942260be9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/2224db607cd2136af3a045ca8b2b8442705f8752 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Shawn-Lin/mmc-block-Use-card_busy-to-detect-busy-state-in-card_busy_detect/20210607-172028 git checkout 2224db607cd2136af3a045ca8b2b8442705f8752 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/mmc/core/block.c:452:2: error: expected statement } while (!mmc_ready_for_data(status)); ^ 1 error generated. vim +452 drivers/mmc/core/block.c a5f5774c55a2e3 drivers/mmc/card/block.c Jon Hunter 2015-09-22 412 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 413 static int card_busy_detect(struct mmc_card *card, unsigned int timeout_ms, a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 414 u32 *resp_errs) a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 415 { a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 416 unsigned long timeout = jiffies + msecs_to_jiffies(timeout_ms); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 417 int err = 0; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 418 u32 status; 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 419 bool busy; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 420 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 421 do { a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 422 bool done = time_after(jiffies, timeout); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 423 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 424 if (card->host->ops->card_busy) { 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 425 busy = card->host->ops->card_busy(card->host); 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 426 status = busy ? 0 : R1_READY_FOR_DATA | R1_STATE_TRAN << 9; 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 427 goto cb; 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 428 } 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 429 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 430 err = __mmc_send_status(card, &status, 5); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 431 if (err) { a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 432 dev_err(mmc_dev(card->host), a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 433 "error %d requesting status\n", err); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 434 return err; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 435 } a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 436 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 437 /* Accumulate any response error bits seen */ a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 438 if (resp_errs) a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 439 *resp_errs |= status; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 440 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 441 /* a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 442 * Timeout if the device never becomes ready for data and never a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 443 * leaves the program state. a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 444 */ a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 445 if (done) { a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 446 dev_err(mmc_dev(card->host), a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 447 "Card stuck in wrong state! %s status: %#x\n", a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 448 __func__, status); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 449 return -ETIMEDOUT; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 450 } 2224db607cd213 drivers/mmc/core/block.c Shawn Lin 2021-06-07 451 cb: 40c96853fef1bd drivers/mmc/core/block.c Ulf Hansson 2020-02-04 @452 } while (!mmc_ready_for_data(status)); a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 453 a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 454 return err; a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 455 } a0d4c7eb71dd08 drivers/mmc/core/block.c Chaotian Jing 2019-09-05 456 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
