On Thu, 13 May 2021 at 21:36, David Gow <davidgow@xxxxxxxxxx> wrote: > > With KUnit's EXPECT macros no longer typechecking arguments as strictly, > get rid of a number of now unnecessary casts. > > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> I guess you will funnel this via another tree than the mmc? Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> Kind regards Uffe > --- > This should be a no-op functionality wise, and while it depends on the > first couple of patches in this series, it's otherwise independent from > the others. I think this makes the test more readable, but if you > particularly dislike it, I'm happy to drop it. > > drivers/mmc/host/sdhci-of-aspeed-test.c | 34 ++++++++++++------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-aspeed-test.c b/drivers/mmc/host/sdhci-of-aspeed-test.c > index bb67d159b7d8..1ed4f86291f2 100644 > --- a/drivers/mmc/host/sdhci-of-aspeed-test.c > +++ b/drivers/mmc/host/sdhci-of-aspeed-test.c > @@ -26,23 +26,23 @@ static void aspeed_sdhci_phase_ddr52(struct kunit *test) > KUNIT_EXPECT_EQ(test, 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 25)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 0, > aspeed_sdhci_phase_to_tap(NULL, rate, 181)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 182)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 183)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 2, > aspeed_sdhci_phase_to_tap(NULL, rate, 184)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 3, > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > aspeed_sdhci_phase_to_tap(NULL, rate, 203)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 204)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 205)); > } > > @@ -67,21 +67,21 @@ static void aspeed_sdhci_phase_hs200(struct kunit *test) > KUNIT_EXPECT_EQ(test, 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 96)); > > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > aspeed_sdhci_phase_to_tap(NULL, rate, 180)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK, > aspeed_sdhci_phase_to_tap(NULL, rate, 185)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 186)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 1, > aspeed_sdhci_phase_to_tap(NULL, rate, 187)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 14, > aspeed_sdhci_phase_to_tap(NULL, rate, 269)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 270)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 271)); > - KUNIT_EXPECT_EQ(test, (int)ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > + KUNIT_EXPECT_EQ(test, ASPEED_SDHCI_TAP_PARAM_INVERT_CLK | 15, > aspeed_sdhci_phase_to_tap(NULL, rate, 276)); > } > > -- > 2.31.1.751.gd2f1c929bd-goog >
