On Mon, 12 Apr 2021 at 11:35, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
>
> On 12/04/2021 08:52, Ulf Hansson wrote:
> > On Wed, 7 Apr 2021 at 11:46, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
> >>
> >> From: Aniruddha Tvs Rao <anrao@xxxxxxxxxx>
> >>
> >> CMD8 is not supported with Command Queue Enabled. Add required callback
> >> to clear CQE_EN and CQE_INTR fields in the host controller register
> >> before sending CMD8. Add corresponding callback in the CQHCI resume path
> >> to re-enable CQE_EN and CQE_INTR fields.
> >>
> >> Reported-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
> >> Tested-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
> >> Signed-off-by: Aniruddha Tvs Rao <anrao@xxxxxxxxxx>
> >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> >
> > Applied for next, thanks!
> >
> > Please tell, if you think this needs to be tagged for stable kernels
> > as well (and if so, perhaps we can set a fixes tag as well?).
>
> Thanks. We were talking about that. I believe that the callbacks were
> only added in v5.10 and so that is the earliest we could apply. The most
> logical fixes tag would be ...
>
> Fixes: 3c4019f97978 ("mmc: tegra: HW Command Queue Support for Tegra SDMMC")
>
> However, this does come before the support for the command queue callbacks.
>
> I would like to get this into the v5.10 stable branch and I can either
> send Greg a direct request once merged or we can tag for stable. Let me
> know what you think.
Let me amend the change and add a stable tag like below:
Cc: stable@xxxxxxxxxxxxxx # v5.10+
Kind regards
Uffe
