Hi Wolfram,
Thanks for your patch.
On 2021-03-09 10:23:31 +0100, Wolfram Sang wrote:
> We will soon allow resetting the whole IP core via a reset controller.
> For this case, DMA must be terminated before the actual reset. For the
> other cases, it is probably better, too.
I agree I think it makes more sens to abort dma before reseting the
device.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/mmc/host/tmio_mmc_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 5aa57640d0e6..eca767dcabba 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -172,11 +172,11 @@ static void tmio_mmc_reset(struct tmio_mmc_host *host)
> sd_ctrl_write16(host, CTL_RESET_SD, 0x0001);
> usleep_range(10000, 11000);
>
> + tmio_mmc_abort_dma(host);
> +
> if (host->reset)
> host->reset(host);
>
> - tmio_mmc_abort_dma(host);
> -
> if (host->pdata->flags & TMIO_MMC_SDIO_IRQ) {
> sd_ctrl_write16(host, CTL_SDIO_IRQ_MASK, host->sdio_irq_mask);
> sd_ctrl_write16(host, CTL_TRANSACTION_CTL, 0x0001);
> --
> 2.30.0
>
--
Regards,
Niklas Söderlund
