On 3/10/21 4:01 AM, Rob Herring wrote:
> On Tue, Mar 09, 2021 at 09:56:29AM +0800, Shawn Lin wrote:
>> This patch adds rockchip support in sdhci-of-dwcmhsc.yaml
>>
>> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>> ---
>>
>> Changes in v3: None
>>
>> .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 24 ++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>> index f99fb9f..43989f2 100644
>> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>> @@ -16,6 +16,7 @@ allOf:
>> properties:
>> compatible:
>> enum:
>> + - rockchip,dwcmshc-sdhci
Compatible strings are supposed to be SoC orientated.
What SoC was this change for? rk3568 ?
Could Shawn confirm that?
- rockchip,rk3568-dwcmshc-sdhci ??
Could Rob advise here?
>> - snps,dwcmshc-sdhci
>>
>> reg:
>> @@ -31,12 +32,24 @@ properties:
>> items:
>> - description: core clock
>> - description: bus clock for optional
>> + - description: axi clock for rockchip specified
>> + - description: block clock for rockchip specified
>> + - description: timer clock for rockchip specified
>> +
>>
>> clock-names:
>> minItems: 1
>> items:
>> - const: core
>> - const: bus
>> + - const: axi
>> + - const: block
>> + - const: timer
>> +
>> + rockchip,txclk-tapnum:
>> + description: Specify the number of delay for tx sampling.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>
> Constraints for this? 0 - 2^32 is okay?
>
>> +
>>
>> required:
>> - compatible
>> @@ -49,6 +62,17 @@ unevaluatedProperties: false
>>
>> examples:
>> - |
>> + mmc@fe310000 {
>> + compatible = "rockchip,dwcmshc-sdhci";
compatible = "rockchip,rk3568-dwcmshc-sdhci"; ??
>> + reg = <0xfe310000 0x10000>;
>> + interrupts = <0 25 0x4>;
>> + clocks = <&cru 17>, <&cru 18>, <&cru 19>, <&cru 20>, <&cru 21>;
>> + clock-names = "core", "bus", "axi", "block", "timer";
>> + bus-width = <8>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> + - |
>> mmc@aa0000 {
>> compatible = "snps,dwcmshc-sdhci";
>> reg = <0xaa000 0x1000>;
>> --
>> 2.7.4
>>
>>
>>
>
