On Fri, 5 Mar 2021 at 03:45, Jia-Ju Bai <baijiaju1990@xxxxxxxxx> wrote: > > My static analysis tool reports that no error return code is assigned in > error handling code of msb_resume(). > However, many other drivers assign error return code in xxx_resume(), > such as sky2_resume() and e1000_resume(). > I wonder whether this is intentional? It's for sure intentional, but it really doesn't matter that much as we are probably in rather dodgy state anyways. Of course, propagating error codes upwards in the stack is always good practise, so feel free to add it. Kind regards Uffe
