Re: [RFC PATCH v2 2/2] mmc: renesas_sdhi: do hard reset if possible

[Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>]

Hi Geert,

> "if (priv->rstc)" if the reset is made optional.

Yes, that would be better.

> > +       priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
> 
> devm_reset_control_get_optional_exclusive()?
> + missing error handling (real errors and -EPROBE_DEFER).

OK.

> Perhaps you want to add a "select RESET_CONTROLLER" to "config
> MMC_SDHI"?

Isn't "select" too strong for an optional feature? I'd think so.

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature