One more comment: On Fri, Jan 29, 2021 at 03:08:25PM +0800, Peng Zhou wrote: > + if (mmc->caps2 & MMC_CAP2_CRYPTO) { > + host->crypto_clk = devm_clk_get(&pdev->dev, "crypto_clk"); > + if (IS_ERR(host->crypto_clk)) > + host->crypto_clk = NULL; > + } I think that clock names aren't supposed to end in "_clk", as this is implied. Just call it "crypto". - Eric