Re: [PATCH v2 1/2] mmc: mediatek: add Inline Crypto Engine support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



One more comment:

On Fri, Jan 29, 2021 at 03:08:25PM +0800, Peng Zhou wrote:
> +	if (mmc->caps2 & MMC_CAP2_CRYPTO) {
> +		host->crypto_clk = devm_clk_get(&pdev->dev, "crypto_clk");
> +		if (IS_ERR(host->crypto_clk))
> +			host->crypto_clk = NULL;
> +	}

I think that clock names aren't supposed to end in "_clk", as this is implied.
Just call it "crypto".

- Eric




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux