Hi Peng,
On Fri, Jan 29, 2021 at 11:39:16AM +0800, Peng Zhou wrote:
> Add Inline Crypto Engine(ICE) support into Mediatek MMC Host.
>
> - add crypto clock control and ungate it before CQHCI init
> - set MMC_CAP2_CRYPTO property of MMC
>
> Change-Id: I6dc35391fd2841609c5be0df1fe1d12ec28ee0c4
> Signed-off-by: Peng Zhou <peng.zhou@xxxxxxxxxxxx>
This is patch 1 of 2, but I only received patch 1. Is there a cover letter and
patch 2 as well?
Also, what branch does this apply too? I tried mmc/next as well as v5.11-rc5,
but neither works.
> ---
> drivers/mmc/host/mtk-sd.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index de09c6347524..e870afd66ae8 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -441,6 +441,7 @@ struct msdc_host {
> struct clk *bus_clk; /* bus clock which used to access register */
> struct clk *src_clk_cg; /* msdc source clock control gate */
> struct clk *sys_clk_cg; /* msdc subsys clock control gate */
> + struct clk *crypto_clk; /* msdc crypto clock */
> struct clk_bulk_data bulk_clks[MSDC_NR_CLOCKS];
Perhaps the new clock should go in bulk_clks so that it doesn't have to be
handled separately?
>
> + /* only eMMC has crypto property */
> +#ifdef CONFIG_MMC_CRYPTO
> + if ((mmc->caps2 & MMC_CAP2_NO_SD) && (mmc->caps2 & MMC_CAP2_NO_SDIO))
> + mmc->caps2 |= MMC_CAP2_CRYPTO;
> +#endif
This #ifdef is unnecessary (i.e., the code can just be unconditional) because
MMC_CAP2_CRYPTO is #defined to 0 when !CONFIG_MMC_CRYPTO.
> + if (mmc->caps2 & MMC_CAP2_CRYPTO) {
> + host->crypto_clk = devm_clk_get(&pdev->dev, "crypto_clk");
> + if (IS_ERR(host->crypto_clk))
> + }
> +
Why is there nothing under IS_ERR()?
- Eric
